TechPrufer
Get started
Shopify
Shopify logoShopify · Feature trail

Code Style Enforcement and Management

1 post · Sep 2017

What this trail covers

Shopify has evolved its code style consistency by introducing RuboCop and developing Policial, a tool that runs on pull requests to enforce these standards. This has involved improving the tool to use GitHub's commit status API for a less noisy experience, extending the Ruby style guide, and enforcing RuboCop in CI to prevent new violations. Efforts are ongoing to fix existing violations and achieve full compliance with the Shopify Ruby style guide.

All Shopify trails
  1. Code Style Consistency for Shopify’s Decade-Old Codebase - ShopifyThis post details the introduction of RuboCop and the development of Policial, a wrapper around RuboCop that runs on pull requests. It describes the evolution of Policial from commenting on lines to using GitHub's commit status API for a less noisy experience. The post also covers the strategy for fixing existing violations by using a bot for Git history and enforcing RuboCop in CI to prevent re-introduction of violations.